Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support change in global account ID - Add allow_context_updates param in sfservice #1417

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

Pooja-08
Copy link

Resolves HCPCFS-3055

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/179400598

The labels on this github issue will be updated when the story is started.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #1417 (860b3c3) into master (375168f) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 860b3c3 differs from pull request most recent head 81af8f4. Consider uploading reports for the commit 81af8f4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   72.98%   72.84%   -0.15%     
==========================================
  Files          44       44              
  Lines        4198     4198              
==========================================
- Hits         3064     3058       -6     
- Misses        809      814       +5     
- Partials      325      326       +1     

@Pooja-08 Pooja-08 force-pushed the issues/Subaccounts_Movement branch 2 times, most recently from 1b33f1f to 87e9b11 Compare September 6, 2021 07:42
@Pooja-08 Pooja-08 changed the title Support change in global account ID Support change in global account ID - Add allow_context_updates param in sfservice Sep 6, 2021
@Pooja-08 Pooja-08 force-pushed the issues/Subaccounts_Movement branch 2 times, most recently from b9ca118 to 4ef9710 Compare September 8, 2021 05:17
@coveralls
Copy link

coveralls commented Sep 8, 2021

Pull Request Test Coverage Report for Build 5573

  • 6 of 17 (35.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 88.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
broker/core/models/src/catalog.js 0 5 0.0%
broker/applications/osb-broker/src/api-controllers/middleware/index.js 6 12 50.0%
Totals Coverage Status
Change from base Build 5560: -0.1%
Covered Lines: 9717
Relevant Lines: 10580

💛 - Coveralls

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n is succeeded.

@Pooja-08 Pooja-08 force-pushed the issues/Subaccounts_Movement branch from 4ef9710 to 4135474 Compare September 8, 2021 09:01
@Pooja-08 Pooja-08 force-pushed the issues/Subaccounts_Movement branch 3 times, most recently from 860b3c3 to 81af8f4 Compare September 9, 2021 08:22
@Pooja-08 Pooja-08 merged commit 77fe6ea into cloudfoundry:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants