Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nodejs to v16.3 #1344

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Upgrade nodejs to v16.3 #1344

merged 1 commit into from
Jun 29, 2021

Conversation

Pooja-08
Copy link

Upgrade nodejs version from v14.16 to v16.3

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/178637457

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 23, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@Pooja-08 Pooja-08 marked this pull request as ready for review June 23, 2021 06:05
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri

This comment has been minimized.

Sign in to view
@cloudfoundry cloudfoundry deleted a comment from vinaybheri Jun 25, 2021
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

anoopjb
anoopjb requested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@anoopjb anoopjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to bump the nodejs version in .travis.yml . So that Travis runs the unit tests with the matching node version.
A related PR is #1285

@Pooja-08
Copy link
Author

We may need to bump the nodejs version in .travis.yml . So that Travis runs the unit tests with the matching node version.
A related PR is #1285

Thanks @anoopjb . Added the changes to the same commit. Ran the unit tests and they all passed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 failed.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n+n+n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@Pooja-08 Pooja-08 merged commit 025bfce into cloudfoundry:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swati1102 swati1102 swati1102 approved these changes

@anoopjb anoopjb anoopjb approved these changes

@jayeshjk jayeshjk Awaiting requested review from jayeshjk

Assignees
No one assigned
Labels
delivered
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pooja-08 @cf-gitbot @vinaybheri @anoopjb @swati1102 @pooja-sap13