Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup timed out Bindings #1311

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

vivekzhere
Copy link
Contributor

  • Issue delete from broker itself

Bug: HCPCFS-2974

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177901322

The labels on this github issue will be updated when the story is started.

@coveralls
Copy link

coveralls commented Apr 25, 2021

Pull Request Test Coverage Report for Build 5368

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 89.248%

Changes Missing Coverage Covered Lines Changed/Added Lines %
broker/applications/osb-broker/src/api-controllers/ServiceBrokerApiController.js 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
broker/core/utils/src/commonFunctions.js 2 86.47%
Totals Coverage Status
Change from base Build 5363: -0.03%
Covered Lines: 9632
Relevant Lines: 10422

💛 - Coveralls

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #1311 (e1263dd) into master (03e42ea) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   71.90%   71.42%   -0.48%     
==========================================
  Files          43       43              
  Lines        3762     3762              
==========================================
- Hits         2705     2687      -18     
- Misses        744      757      +13     
- Partials      313      318       +5     

- Issue delete from broker itself

Bug: HCPCFS-2974
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vivekzhere vivekzhere merged commit 63818d6 into cloudfoundry:master Apr 26, 2021
@vivekzhere vivekzhere deleted the binding_cleanup branch April 26, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants