Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Lazy Replication of SFService and SFPlan #1261

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Lazy Replication of SFService and SFPlan #1261

merged 1 commit into from
Mar 12, 2021

Conversation

vivekzhere
Copy link
Contributor

  • Replicate these as part of Instance Replicator
  • Remove SFService Replicator

Fetaure: HCPCFS-2505

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 22, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Vivek Anand T Kallampally (90dad94)

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177035060

The labels on this github issue will be updated when the story is started.

@codecov
Copy link

codecov bot commented Feb 22, 2021 •
edited
Loading

Codecov Report

Merging #1261 (e1121ae) into master (b55c27a) will decrease coverage by 0.03%.
The diff coverage is 58.02%.

@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
- Coverage   71.36%   71.32%   -0.04%     
==========================================
  Files          44       43       -1     
  Lines        3817     3749      -68     
==========================================
- Hits         2724     2674      -50     
+ Misses        772      757      -15     
+ Partials      321      318       -3

@coveralls
Copy link

coveralls commented Feb 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 5203

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 89.153%
Files with Coverage Reduction New Missed Lines %
broker/data-access-layer/cf/src/TokenIssuer.js 1 98.55%
Totals Coverage Status
Change from base Build 5201: -0.007%
Covered Lines: 9446
Relevant Lines: 10224
💛 - Coveralls

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-1 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n-2 is succeeded.

@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

1 similar comment
@vinaybheri
Copy link
Contributor

Validation on k8s cluster: n is succeeded.

jayeshjk
jayeshjk approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@jayeshjk jayeshjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lazy Replication of SFService and SFPlan
e1121ae 
- Replicate these as part of Instance Replicator
- Remove SFService Replicator

Fetaure: HCPCFS-2505
@vivekzhere
Copy link
Contributor Author

Rebased with master

@vivekzhere vivekzhere merged commit 54a23db into cloudfoundry:master Mar 12, 2021
@vivekzhere vivekzhere deleted the lazy branch March 12, 2021 06:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jayeshjk jayeshjk jayeshjk approved these changes

@subhankarc subhankarc subhankarc approved these changes

@anoopjb anoopjb Awaiting requested review from anoopjb

@anujbansal16 anujbansal16 Awaiting requested review from anujbansal16

Assignees
No one assigned
Labels
enhancement PipeLine:Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vivekzhere @cf-gitbot @coveralls @vinaybheri @subhankarc @jayeshjk