Skip to content

Commit

Permalink
Move node-semver to submodule and upgrade
Browse files Browse the repository at this point in the history
- Despite the name, this is a python package
- The whole git module was vendored, so making it a submodule will make
  it easier to upgrade in the future
- Upgrade to the latest version to remove python3 syntax warnings from
  app staging logs
  • Loading branch information
Gerg authored and robdimsdale committed Sep 11, 2024
1 parent acbfbbe commit 315ab98
Show file tree
Hide file tree
Showing 25 changed files with 5 additions and 1,995 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@
[submodule "fixtures/composer_no_index_dot_php/vendor/psr/log"]
path = fixtures/composer_no_index_dot_php/vendor/psr/log
url = https://github.com/php-fig/log
[submodule "python-vendor/node-semver"]
path = python-vendor/node-semver
url = git@github.com:podhmo/python-node-semver.git
2 changes: 1 addition & 1 deletion extensions/composer/extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from extension_helpers import ExtensionHelper

sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '..', 'python-vendor', 'node-semver'))
from semver import max_satisfying
from nodesemver import max_satisfying

from build_pack_utils.compile_extensions import CompileExtensions

Expand Down
1 change: 1 addition & 0 deletions python-vendor/node-semver
Submodule node-semver added at 759097
54 changes: 0 additions & 54 deletions python-vendor/node-semver/.gitignore

This file was deleted.

1 change: 0 additions & 1 deletion python-vendor/node-semver/CHANGES.txt

This file was deleted.

21 changes: 0 additions & 21 deletions python-vendor/node-semver/LICENSE

This file was deleted.

9 changes: 0 additions & 9 deletions python-vendor/node-semver/Makefile

This file was deleted.

23 changes: 0 additions & 23 deletions python-vendor/node-semver/README.rst

This file was deleted.

16 changes: 0 additions & 16 deletions python-vendor/node-semver/demo.py

This file was deleted.

Loading

0 comments on commit 315ab98

Please sign in to comment.