Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to Go1.22 #38

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

aqstack
Copy link
Contributor

@aqstack aqstack commented Jul 26, 2024

No description provided.

@aqstack aqstack requested a review from a team as a code owner July 26, 2024 16:59
ctlong
ctlong previously requested changes Jul 26, 2024
Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/otel-collector/go.mod is a generated file. Did you update it manually? When I run the regenerate script I don't get this result.

@aqstack
Copy link
Contributor Author

aqstack commented Jul 26, 2024

src/otel-collector/go.mod is a generated file. Did you update it manually? When I run the regenerate script I don't get this result.

Yes, I added it manually after verifying what the regenerate script does. How about we add go mod edit -go 1.22.0 command in the regenerate script. Snippet from the modified script:

 pushd "${release_dir}/src/otel-collector"
     go get toolchain@none
     go mod edit -go 1.22.0
     go mod tidy
     go mod vendor
 popd

@ctlong
Copy link
Member

ctlong commented Jul 26, 2024

Why force the generated go.mod to have go1.22 set as the minimum? We would prefer for the minimum go version required to match the go version we're using, but it seems to me more of a nice-to-have than a requirement. And in that case, I don't think it's worth building in a workaround for the generated files.

What do you think?

Copy link

linux-foundation-easycla bot commented Jul 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mkocher / name: Matthew Kocher (47b6b88)

Signed-off-by: Ausaf Ahmed <ausaf.ahmed@broadcom.com>
Co-authored-by: Ausaf Ahmed <ausaf.ahmed@broadcom.com>
@aqstack
Copy link
Contributor Author

aqstack commented Jul 26, 2024

I agree, it's more of a nice-to-have than a requirement. I've reverted the manual change. Thanks for the feedback!

@aqstack aqstack requested a review from ctlong July 26, 2024 21:45
@mkocher mkocher merged commit 19265d7 into cloudfoundry:main Jul 29, 2024
5 checks passed
@mkocher mkocher deleted the bump-go1.22 branch July 29, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants