-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to Go1.22 #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/otel-collector/go.mod
is a generated file. Did you update it manually? When I run the regenerate script I don't get this result.
Yes, I added it manually after verifying what the regenerate script does. How about we add
|
Why force the generated go.mod to have go1.22 set as the minimum? We would prefer for the minimum go version required to match the go version we're using, but it seems to me more of a nice-to-have than a requirement. And in that case, I don't think it's worth building in a workaround for the generated files. What do you think? |
|
Signed-off-by: Ausaf Ahmed <ausaf.ahmed@broadcom.com> Co-authored-by: Ausaf Ahmed <ausaf.ahmed@broadcom.com>
I agree, it's more of a nice-to-have than a requirement. I've reverted the manual change. Thanks for the feedback! |
No description provided.