Skip to content

Commit

Permalink
Make disk type examples consistent across CPIs
Browse files Browse the repository at this point in the history
Makes formatting consistent and removes references to the v1 disk_pools
(v2 disk_types).

Signed-off-by: Brian Upton <bupton@vmware.com>
  • Loading branch information
klakin-pivotal authored and ystros committed Apr 5, 2023
1 parent 8841217 commit ea1e362
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 11 deletions.
3 changes: 1 addition & 2 deletions content/aws-cpi.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Schema for `cloud_properties` section:
* `gp3` stands for EBS next-generation general purpose drives (SSD)
* **iops** [Integer, optional]: Specifies the number of I/O operations per second to provision for the drive.
* Only valid for `io1` and `gp3` type drive.
* Required when `io1` type drive is specified.
* Required when `io1` type drive is specified.
* Optional for `gp3`, defaults to AWS default iops count if iops < AWS default (added with [v93](https://github.com/cloudfoundry/bosh-aws-cpi-release/releases/tag/v93)).
* **throughput** [Integer, optional]: Specifies Throughput in MBp/s
* Only valid for `gp3` type drive.
Expand Down Expand Up @@ -151,7 +151,6 @@ EBS volumes are created in the availability zone of an instance that volume will
Example of 10GB disk:

```yaml
disk_pools:
- name: default
disk_size: 10_240
cloud_properties:
Expand Down
4 changes: 1 addition & 3 deletions content/azure-cpi.md
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,9 @@ Schema for `cloud_properties` section:

* **caching** [String, optional]: Type of the disk caching. It can be either `None`, `ReadOnly` or `ReadWrite`. Default is `None`.
* **storage\_account\_type** [String, optional]: Storage account type. Valid only when `use_managed_disks` is `true`. It can be either `Standard_LRS` or `Premium_LRS`. You can click [**HERE**](http://azure.microsoft.com/en-us/pricing/details/storage/) to learn more about the type of Azure storage account.

Example of 10GB disk:

* **disk_size** [Integer, required]: Size of the disk in MiB. On Azure the disk size must be greater than 1 * 1024 and less than the max disk size for [unmanaged](https://azure.microsoft.com/en-us/pricing/details/storage/unmanaged-disks/) or [managed](https://azure.microsoft.com/en-us/pricing/details/managed-disks/) disk. Please always use `N * 1024` as the size because Azure always uses GiB not MiB.

Example of 10GB disk:
```yaml
disk_types:
- name: default
Expand Down
3 changes: 1 addition & 2 deletions content/openstack-cpi.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,9 @@ Schema for `cloud_properties` section:

Cinder volumes are created in the availability zone of an instance that volume will be attached.

Example of 10GB SSD disk:
Example of 10GB disk:

```yaml
disk_pools:
- name: default
disk_size: 10_240
cloud_properties:
Expand Down
5 changes: 1 addition & 4 deletions content/vsphere-cpi.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,13 @@ Schema for `cloud_properties` section:
Example of 10GB disk:

```yaml
disk_pools:
- name: default
disk_size: 10_240
```

Example of disk with type eagerZeroedThick:

```yaml
disk_pools:
- name: default
disk_size: 10_240
cloud_properties:
Expand All @@ -197,7 +195,6 @@ disk_pools:
Example of disk stored in specific datastores:

```yaml
disk_pools:
- name: default
disk_size: 10_240
cloud_properties:
Expand Down Expand Up @@ -464,7 +461,7 @@ For any VM created on this cluster with host group specification , vSphere CPI

When placing a VM, a cluster is chosen (along with a datastore) based on the VM's memory, ephemeral disk, and persistent disk requirements.

VMs are placed on clusters and datastores based on a weighted random algorithm. The weights are calculated by how many times the requested memory, ephemeral and persistent disk could fit on the cluster.
VMs are placed on clusters and datastores based on a weighted random algorithm. The weights are calculated by how many times the requested memory, ephemeral and persistent disk could fit on the cluster.

This means the VMs will be placed according to the following rules.

Expand Down

0 comments on commit ea1e362

Please sign in to comment.