fix: S3 - Add dependency on aws_s3_bucket_public_access_block to reduce flakiness on provision #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce flakiness on provision We have seen issues with the S3 provioning failing at timesbeccasue of bucket ACL issues. There are a few aticles refering to changes to the AWS provider that point out that the `s3_bucket_public_access_block` should be the first one to be created. See links: [1](hashicorp/terraform-provider-aws#30951 (comment)) and [2](https://stackoverflow.com/questions/76419099/access-denied-when-creating-s3-bucket-acl-s3-policy-using-terraform) [#187284776](https://www.pivotaltracker.com/story/show/187284776)
pivotal-marcela-campo
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen issues with the S3 provioning failing at timesbeccasue of bucket ACL issues. There are a few aticles refering to changes to the AWS provider that point out that the
s3_bucket_public_access_blockshould be the first one to be created.See links: 1 and 2
#187284776
Checklist:
make run-integration-testsandmake run-terraform-tests?