feat: migrate to OpenTofu #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-marcela-campo
force-pushed
the
feat_use_tofu
branch
from
b0fa196 to
28e1fb9
Compare
zucchinidev
approved these changes
Mar 25, 2024
| source: https://github.com/hashicorp/terraform/archive/v1.5.7.zip | ||
| - name: tofu | ||
| version: 1.6.1 | ||
| source: https://github.com/opentofu/opentofu/archive/refs/tags/v1.6.1.zip |
There was a problem hiding this comment.
question: I see that we have added this link in the other brokerpaks, but I was wondering why we now use refs/tags/v1.6.1.zip instead of archive/v1.6.1.zip. Is there an advantage?
There was a problem hiding this comment.
not really, it is just the url I got from github.
| @@ -68,11 +70,11 @@ func ShowPlan(dir string, vars map[string]any) tfjson.Plan { | |||
| } | |||
|
|
|||
| func terraformPlanCMD(dir string, planFile string) *exec.Cmd { | |||
There was a problem hiding this comment.
question: do we want to change the name of the method and use func createPlanCMD(dir string, planFile string) *exec.Cmd {?
There was a problem hiding this comment.
good spot, I'll pr that change separately in all the brokerpaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187199931
Checklist:
make run-integration-testsandmake run-terraform-tests?