fix: allow null values for iops #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-marcela-campo
force-pushed
the
iops-null
branch
from
4ecc9c2 to
b9b447e
Compare
When creating rds instances an iops value of 0 is interpreted by downstream services as null value. However when updating this is not the case. Hence when trying to update a service where setting iops is not permitted by AWS, update operations error even when we are not trying to change the iops value. Allowing nulls for this property works as expected both for provisioning and update. [#187149548](https://www.pivotaltracker.com/story/show/187149548)
zucchinidev
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating rds instances an iops value of 0 is interpreted by downstream services as null value. However when updating this is not the case. Hence when trying to update a service where setting iops is not permitted by AWS, update operations error even when we are not trying to change the iops value. Allowing nulls for this property works as expected both for provisioning and update.
#187149548
Checklist:
make run-integration-testsandmake run-terraform-tests?