feat: first basic version of DLQ #1539
Conversation
| type: string | ||
| details: ARN of the Dead Letter Queue. If provided, configures redrive_policy for the queue. | ||
| default: "" | ||
| - field_name: max_receive_count |
There was a problem hiding this comment.
We did at one point talk about prefixing DLQ field names so this could be dlq_max_receive_count.
This may be something we can change later, and could be added to the story about adding properties.
There was a problem hiding this comment.
I'm going to change it now to establish the style for the next changes. Thank you @blgm
There was a problem hiding this comment.
Strictly speaking, max_receive_count is connected to the redrive policy.
In that sense is connected to the DLQ as much as it is connected to the Source queue.
maxReceiveCount
The redrive policy specifies the source queue, the dead-letter queue, and the conditions under which Amazon SQS moves messages from the former to the latter if the consumer of the source queue fails to process a message a specified number of times. The maxReceiveCount is the number of times a consumer tries receiving a message from a queue without deleting it before being moved to the dead-letter queue.
Are we really improving anything by prefixing it?
I don't have any strong opinions for this specific case.
I have some really strong opinions about not deviating too much from Terraform property names (maxReceiveCount -> max_receive_count).
I also have some really strong opinions about overcrowding properties with prefixes.
zucchinidev
force-pushed
the
dlq_implementation_base
branch
from
40c08d5 to
8c698e5
Compare
zucchinidev
force-pushed
the
dlq_implementation_base
branch
from
8c698e5 to
4c7c422
Compare
#186768799
Checklist:
make run-integration-testsandmake run-terraform-tests?