feat: SQS standard queues (experimental) #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial steel thread, and should be considered experimental at this stage. [#186768674](https://www.pivotaltracker.com/story/show/186768674)
zucchinidev
reviewed
Jan 30, 2024
zucchinidev
requested changes
Jan 30, 2024
| @@ -0,0 +1,5 @@ | |||
| resource "aws_sqs_queue" "queue" { | |||
| name = var.instance_name | |||
| fifo_queue = false | |||
There was a problem hiding this comment.
praise: thanks for being explicit with this value. It will help in the next iteration
terraform/sqs/provision/versions.tf
Outdated
| required_providers { | ||
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 4.0" |
There was a problem hiding this comment.
suggestion: version = ">= 5.0"
blgm
added a commit
that referenced
this pull request
Jan 31, 2024
In PR #1503 some copy/pasted old practices were identified in a code review. This brings all services consistently to the same standard. [#186768674](https://www.pivotaltracker.com/story/show/186768674)
zucchinidev
approved these changes
Jan 31, 2024
zucchinidev
pushed a commit
that referenced
this pull request
Jan 31, 2024
In PR #1503 some copy/pasted old practices were identified in a code review. This brings all services consistently to the same standard. [#186768674](https://www.pivotaltracker.com/story/show/186768674)
zucchinidev
pushed a commit
that referenced
this pull request
Jan 31, 2024
In PR #1503 some copy/pasted old practices were identified in a code review. This brings all services consistently to the same standard. [#186768674](https://www.pivotaltracker.com/story/show/186768674)
fnaranjo-vmw
added a commit
that referenced
this pull request
Feb 1, 2024
[#186768674](https://www.pivotaltracker.com/story/show/186768674) An alternative implementation of the work done in: #1503 We as a team decided it was worth experimenting with this alternative approach for the steel thread for FIFO queues story [#186768689](https://www.pivotaltracker.com/story/show/186768689) but since its description clearly states "Build on #186768674" I felt I needed to extend the experiment to that story as well. This experiment uses terraform-aws-sqs as a submodule because it suits better our existing workflow, however it shouldn't be necessary at all since modules can simply point at gh repos: https://developer.hashicorp.com/terraform/language/modules/sources#github Should we decide that we want to remove the submodule we would need to modidy our brokerpak packaging scripts to ensure that we embed a local copy of the module (which is not hard to do).
blgm
added a commit
that referenced
this pull request
Feb 2, 2024
Extends the work in #1503 to add FIFO queues as an option As before, this should be considered experimental at this stage. [#186768689](https://www.pivotaltracker.com/story/show/186768689)
blgm
added a commit
that referenced
this pull request
Feb 5, 2024
Extends the work in #1503 to add FIFO queues as an option As before, this should be considered experimental at this stage. [#186768689](https://www.pivotaltracker.com/story/show/186768689)
pivotal-marcela-campo
pushed a commit
that referenced
this pull request
Feb 6, 2024
Extends the work in #1503 to add FIFO queues as an option As before, this should be considered experimental at this stage. [#186768689](https://www.pivotaltracker.com/story/show/186768689)
blgm
added a commit
that referenced
this pull request
Feb 6, 2024
Extends the work in #1503 to add FIFO queues as an option As before, this should be considered experimental at this stage. [#186768689](https://www.pivotaltracker.com/story/show/186768689)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial steel thread, and should be considered experimental at this stage.
#186768674