Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: TF test failing when invalid engine version #1104

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

zucchinidev
Copy link
Contributor

Checklist:

  • [ ] Have you added Release Notes in the docs repositories?
  • Have you ran make run-integration-tests and make run-terraform-tests?
  • [ ] Have you ran acceptance tests for the service under change?
  • Have you followed the Conventional Commits specification?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185882394

The labels on this github issue will be updated when the story is started.

Copy link
Contributor

@fnaranjo-vmw fnaranjo-vmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic fix.
Great job documenting with a test after latest changes we require a valid mssql_version even during apply.

@zucchinidev zucchinidev merged commit 57cf798 into main Aug 22, 2023
@blgm blgm deleted the fix_terraform_tests_mssql branch November 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants