feat: [MSSQL] expose publicly_accessible property #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zucchinidev
requested changes
Aug 18, 2023
integration-tests/mssql_test.go
Outdated
| @@ -53,6 +53,7 @@ var _ = Describe("MSSQL", Label("MSSQL"), func() { | |||
| "rds_subnet_group": "some-rds-subnet-group", | |||
| "instance_class": "some-instance-class", | |||
| "max_allocated_storage": 999, | |||
| "publicly_accessible": false, | |||
There was a problem hiding this comment.
nit-pick: this property is not needed. The default value is propagate
There was a problem hiding this comment.
Feel free to remove it. I have the tendency to add every new field to some of the maps in the tests (required, optional, defaults, etc.)
zucchinidev
reviewed
Aug 21, 2023
Co-authored-by: Andrea Zucchini <zandrea@vmware.com>
zucchinidev
approved these changes
Aug 21, 2023
zucchinidev
deleted the
feat-mssql-expose-publicly-accessible-#185201362
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#185201362]
Checklist:
make run-integration-testsandmake run-terraform-tests?