feat: creation MSSQL Terraform provider #1085
Conversation
Proof of concept to understand how bindings work in MSSQL. The provider developed in the Azure Brokerpak has been used as a coding base with slight modifications for the connection chain. The database is not created when the servier is created. So it is necessary to execute the create database sentence. It is necessary to use an option group called "contained database authentication" to create the contained database. [#185149821](https://www.pivotaltracker.com/story/show/185149821)
It is a copy of the provider used in Azure, with minimal changes for the AWS adaptation. The idea is to keep it practically identical until the final integration. [#185151996](https://www.pivotaltracker.com/story/show/185151996)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185836110 The labels on this github issue will be updated when the story is started. |
zucchinidev
changed the title
| var _ = BeforeSuite(func() { | ||
| adminPassword = testhelpers.RandomPassword() | ||
| port = testhelpers.FreePort() | ||
| session := testhelpers.StartServer(adminPassword, port) |
There was a problem hiding this comment.
This StartServer set up creates a database. So strictly speaking we are only testing that we can connect and create bindings when the database is already there. We are missing testing the scenario when the database has not yet been created.
There was a problem hiding this comment.
Discussed with @zucchinidev and agreed to provide the tests in a separate pull request to unblock other tasks. The scanario missing is tested with acceptance tests as well and those pass, so we have confidence this works.
|
Created a PR to replace the modules mentioned in my comments: |
#185151996
Checklist:
make run-integration-testsandmake run-terraform-tests?