feat: [MSSQL] expose support for storage autoscale #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zucchinidev
approved these changes
Aug 9, 2023
| @@ -214,5 +216,28 @@ var _ = Describe("MSSQL", Label("MSSQL"), func() { | |||
| Entry("update instance_name", "instance_name", "no-matter-what-instance-name"), | |||
| Entry("update rds_vpc_security_group_ids", "rds_vpc_security_group_ids", "no-matter-what-security-group"), | |||
| ) | |||
|
|
|||
| DescribeTable("should allow unsetting properties flagged as `nullable` by explicitly updating their value to be `nil`", | |||
There was a problem hiding this comment.
praise: thank you very much for adding this test!! ❤️
[#185149499] This implementation doesn't follow conventions stablished in mysql or postgresql on how to expose storage autoscale. A larger discussion of the reasons can be found in the tracker story. The summary is we no longer need to. We can now define nullable numbers which were impossible before we can also use Terraform preconditions to validate inputs, etc
pivotal-marcela-campo
force-pushed
the
feat-mssql-enable-autoscale-#185149499
branch
from
c1965c9 to
54beb64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#185149499]
This implementation doesn't follow conventions stablished in mysql or postgresql on how to expose storage autoscale.
A larger discussion of the reasons can be found in the tracker story. The summary is we no longer need to.
We can now define nullable numbers which were impossible before we can also use Terraform preconditions to validate inputs, etc
Checklist: