Skip to content

Commit

Permalink
fix: [MSSQL] instance_class have useless default
Browse files Browse the repository at this point in the history
[#185798501]
  • Loading branch information
fnaranjo-vmw committed Aug 9, 2023
1 parent f2e681e commit 4e9061b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion aws-mssql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ provision:
details: |
AWS DB instance class. Accepted values will depend on the selected engine and mssql_version.
See: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_SQLServer.html#SQLServer.Concepts.General.InstanceClasses
default: ""
- field_name: rds_subnet_group
type: string
details: AWS RDS subnet group already in existence to use
Expand Down
6 changes: 4 additions & 2 deletions terraform-tests/mssql_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ var _ = Describe("mssql", Label("mssql-terraform"), Ordered, func() {
"labels": map[string]string{"label1": "value1"},

"aws_vpc_id": "",
"instance_class": "",
"rds_subnet_group": "",
"rds_vpc_security_group_ids": "",
}
Expand All @@ -38,6 +37,8 @@ var _ = Describe("mssql", Label("mssql-terraform"), Ordered, func() {
"engine": "sqlserver-ee",
"mssql_version": "some-engine-version",
"storage_gb": 20,

"instance_class": "some-instance-class",
}

validVPC := awsVPCID
Expand Down Expand Up @@ -71,7 +72,7 @@ var _ = Describe("mssql", Label("mssql-terraform"), Ordered, func() {
"engine_version": Equal("some-engine-version"),
"identifier": Equal("csb-mssql-test"),
"storage_encrypted": BeTrue(),
"instance_class": Equal(""),
"instance_class": Equal("some-instance-class"),
"tags": HaveKeyWithValue("label1", "value1"),
"db_subnet_group_name": Equal("csb-mssql-test-p-sn"),
"apply_immediately": BeTrue(),
Expand All @@ -89,6 +90,7 @@ var _ = Describe("mssql", Label("mssql-terraform"), Ordered, func() {
Expect(msgs).To(ContainSubstring(`The root module input variable \"mssql_version\" is not set, and has no default value.`))
Expect(msgs).To(ContainSubstring(`The root module input variable \"engine\" is not set, and has no default value.`))
Expect(msgs).To(ContainSubstring(`The root module input variable \"storage_gb\" is not set, and has no default value.`))
Expect(msgs).To(ContainSubstring(`The root module input variable \"instance_class\" is not set, and has no default value.`))
})
})

Expand Down

0 comments on commit 4e9061b

Please sign in to comment.