Optimize service instances SQL query efficiency #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service instances cannot have duplicate values due to the primary key constraint on GUID, so using distinct is not only redundant but also affects query performance. Co-authored-by: Shahnavaz Valayil <shahnavaz.valayil@broadcom.com>
a-b
changed the title
sethboyles
requested changes
Sep 6, 2024
There was a problem hiding this comment.
It's unfortunate we didn't have a test in place for why this is needed, but I'm adding one with this PR:
We need this DISTINCT clause due to the left join on service_instance_shares. If a Service Instance has been shared with two or more spaces the user belongs to, that will result in duplicate SIs in the query results
|
@sethboyles, thanks for your feedback. At least we improved test coverage. We will keep iterating on this PR to find alternative ways to improve query performance. Our current goals are:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service instances cannot have duplicate values due to the primary key constraint on GUID, so using distinct is not only redundant but also affects query performance.
Co-authored-by: @shahnavaz
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests