Replace jobs_user_guid_index with jobs_user_guid_state_index
#3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the jobs table is large and single users have also a large amount of jobs, which are mostly in state `COMPLETED`, postgres might decide to not use the index on `user_guid` column and scan the table with other methods, which are much slower. This commit removes the index on user_guid column and adds a new partial index on user_guid and state where state is either `POLLING` or `PROCESSING`. This keeps the index much smaller and improves the query performance drastically. MySQL does not support partial indexes.
svkrieger
force-pushed
the
replace_jobs_user_guid_index_with_jobs_user_guid_state_index
branch
from
d474230
to
6c7c13a
Compare
svkrieger
deleted the
replace_jobs_user_guid_index_with_jobs_user_guid_state_index
branch
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 22, 2024
Changes in cloud_controller_ng:
- Replace `jobs_user_guid_index` with `jobs_user_guid_state_index`
PR: cloudfoundry/cloud_controller_ng#3934
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Replacing
jobs_user_guid_indexwith partial indexjobs_user_guid_state_indexfor Postgres.An explanation of the use cases your change solves
When the jobs table is large and single users have also a large amount of jobs, which are mostly in state
COMPLETED, postgres might decide to not use the index onuser_guidcolumn and scan the table with other methods, which are much slower. This commit removes the index on user_guid column and adds a new partial index on user_guid and state where state is eitherPOLLINGorPROCESSING. This keeps the index much smaller and improves the query performance drastically.MySQL does not support partial indexes.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests