Fix documentation to specify when revisions are created. #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this should allign with the messages that are created within revisions https://github.com/cloudfoundry/cloud_controller_ng/blob/11ef2a547e6c50001a65e49855c159aecdb32381/app/actions/revision_resolver.rb#L60-L62 - we confirmed that revisions are not created when running tasks on a --tasks pushed application or when the app is pushed with the app is pushed with the task config
More usage data on when revisions are created
|
Samze
approved these changes
Aug 5, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 5, 2024
Changes in cloud_controller_ng:
- Fix documentation to specify when revisions are created.
PR: cloudfoundry/cloud_controller_ng#3920
Author: Benjamin Fuller <ben.fuller@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloud_controller_ng/app/actions/revision_resolver.rb
Lines 60 to 62 in 11ef2a5
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rake(no code changes)
(no code changes)