Fix rotate database key spec #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbender
force-pushed
the
fixRotateDatabase
branch
2 times, most recently
from
19deac2
to
abad0d0
Compare
Co-authored-by: Nicolas Bender <nicolas.bender@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
nicolasbender
force-pushed
the
fixRotateDatabase
branch
from
abad0d0
to
0521fe5
Compare
1 task
johha
approved these changes
Jun 7, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
The rotate database key tests for unencrypted fields check for the presence of values only which excludes model instances with nil values. We propose to exclude all columns with nil values from this check.
An explanation of the use cases your change solves
We want to introduce a new foreign key cnb_lifecycle_data in buildpack_lifecycle_buildpack_model which could be nil. This test prevents the check to pass.
Links to any other associated PRs
[RFC0028] Implement Cloud Native Buildpacks lifecycle #3778
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests