Expose process CPU Entitlement in stats #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assert that we don't create a container metric batch when the envelopes contain no container metrics - Change example units for cpu and log rate Co-authored-by: Matthew Kocher <matthew.kocher@broadcom.com>
- There is existing logic to set all container metrics to zero when any given reported container metric is missing. - Chose not to implement the same behaviour for cpu_entitlement as this would prevent other stats from being available before Diego Cells are upgraded. Co-authored-by: Matthew Kocher <matthew.kocher@broadcom.com>
Co-authored-by: Matthew Kocher <matthew.kocher@broadcom.com>
Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com>
sethboyles
approved these changes
Feb 21, 2024
acrmp
added a commit
to loggregator/cloud_controller_ng
that referenced
this pull request
Jun 19, 2024
- In cloudfoundry#3641 we exposed CPU Entitlement in process stats and returned null when stats are not yet available in Log Cache. - Change missing process stats to instead have CPU Entitlement of zero for consistency with other existing metrics. Recent versions of the cf CLI will show zero rather than an empty column for CPU Entitlement. - CPU Entitlement may still be null when the metric is not available on the deployment. Signed-off-by: Andrew Costa <andrew.costa@broadcom.com>
5 tasks
philippthun
pushed a commit
that referenced
this pull request
Jun 28, 2024
- In #3641 we exposed CPU Entitlement in process stats and returned null when stats are not yet available in Log Cache. - Change missing process stats to instead have CPU Entitlement of zero for consistency with other existing metrics. Recent versions of the cf CLI will show zero rather than an empty column for CPU Entitlement. - CPU Entitlement may still be null when the metric is not available on the deployment. Signed-off-by: Andrew Costa <andrew.costa@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
Extend the existing v3 processes stats endpoint to include the CPU Entitlement for the process.
It can be difficult to reason about process CPU usage using the existing cpu stat. For example the value is impacted by changes to the underlying vCPUs available on the Diego Cell. CPU Entitlement is a more generally useful metric.
https://www.cloudfoundry.org/blog/better-way-split-cake-cpu-entitlements/
cloudfoundry/diego-release#897
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests
@mkocher