Adds microsecond timestamp precision on the asg_latest_update table #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around race conditions seen when policy-server-asg-syncer polls cloud_controller in between two ASG updates of the same second. Fixes cloudfoundry#3479 - cloudfoundry#3479 Signed-off-by: Geoff Franks <gfranks@vmware.com> Co-authored-by: Geoff Franks <gfranks@vmware.com>
Signed-off-by: Josh Russett <jrussett@vmware.com> Co-authored-by: Josh Russett <jrussett@vmware.com>
philippthun
reviewed
Oct 20, 2023
db/migrations/20231016094900_microsecond_timestamp_msql_asg_update.rb
Outdated
Show resolved
Hide resolved
spec/migrations/20231016094900_microsecond_timestamp_msql_asg_update_spec.rb
Outdated
Show resolved
Hide resolved
spec/migrations/20231016094900_microsecond_timestamp_msql_asg_update_spec.rb
Outdated
Show resolved
Hide resolved
philippthun
reviewed
Oct 26, 2023
spec/migrations/20231016094900_microsecond_timestamp_msql_asg_update_spec.rb
Outdated
Show resolved
Hide resolved
spec/migrations/20231016094900_microsecond_timestamp_msql_asg_update_spec.rb
Outdated
Show resolved
Hide resolved
…ration Signed-off-by: Amelia Downs <adowns@vmware.com> Co-authored-by: Amelia Downs <adowns@vmware.com>
|
@philippthun sounds good, we made the requested changes on the migrations spec. Thanks for all the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around race conditions seen when policy-server-asg-syncer polls cloud_controller in between two ASG updates of the same second.
Fixes #3479
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests