Adds run_rootfs_image and build_rootfs_image stack properties to API output #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests really validate what happens when the CC config is missing these values, not what happens when the stack is 'nonexistent'
There were two ways off accessing the stack name provided by the lifecycle_data -- 'lifecycle_stack' and '@stack'. Decided to get rid of one
…y resemble task_action_builder
… in requests to Diego
Otherwise, falls back to stack name
Otherwise, falls back to stack name
Otherwise, falls back to stack name
dsabeti
force-pushed
the
stacks-api-enhancments
branch
from
fdc8c93
to
2f3fbb9
Compare
|
closing and reopening to see if easycla gets happier |
sethboyles
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
Adds the
run_rootfs_imageandbuild_rootfs_imageproperties to API output in the /v3/stacks endpoint.Allows API users to see what specific stack images are being used with different stacks when building/staging, and running LRPs/tasks.
This branch was built off of the #3328 and shares most of its commits with it. We can rebase off of main after that's merged if desired. You should be able to look specifically at this commit's changes for this PR though.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests