Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud controller logs have too much low-information entries #384

Closed
ericpromislow opened this issue May 27, 2015 · 3 comments
Closed

Cloud controller logs have too much low-information entries #384

ericpromislow opened this issue May 27, 2015 · 3 comments

Comments

@ericpromislow
Copy link
Contributor

The logs for parse_params, cc.read, and cc.enumerate.related should be downgraded to DEBUG2. They fill up the logs and rotate more useful messages to secondary files, and quickly to oblivion.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/95554146.

ericpromislow pushed a commit to hpcloud/cloud_controller_ng that referenced this issue May 27, 2015
@zaksoup
Copy link
Contributor

zaksoup commented Jun 4, 2015

Hi @ericpromislow, thanks for submitting this issue!

We appreciate your input when describing this issue, however we find the information in these log messages useful when debugging. As such we will not be changing log levels at this time.

Best,
@zaksoup + @wendorf, CF Runtime Team

@zaksoup zaksoup closed this as completed Jun 4, 2015
@ericpromislow
Copy link
Contributor Author

We just reopened discussion on this issue, and fail to see how any of the affected messages are useful. Place log.debug messages in two broad categories: 1: log potentially anomalous, and infrequent, conditions in the field that could be useful to support teams, and (2): emit messages that help the developers better understand their code. I would say we have no business pushing type-2 log.debug messages into production, especially when they cause logs to turn over in less than a minute on busy clusters. @zaksoup and @wendorf, could you explain some specific benefits of retaining these statements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants