fix: removed redundant data from service_instance_details table #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils table. Storing this data in the service_instance_details table is redundant, since this information is also stored the terraform_deployment table. If these two sources of truth became inconsistent, there is a possiblity that a service details could be deleted incorrectly following a failed deletion. Having a single source of truth prevents this incorrect behaviour. [#TPCF-26508](https://vmw-jira.broadcom.com/browse/TPCF-26508)
blgm
approved these changes
Oct 3, 2024
brokerapi/broker/deprovision.go
Outdated
| @@ -94,6 +94,8 @@ func (broker *ServiceBroker) Deprovision(ctx context.Context, instanceID string, | |||
| return domain.DeprovisionServiceSpec{}, err | |||
| } | |||
|
|
|||
| fmt.Println("serviceProvider Deprovsion") | |||
| @@ -31,12 +31,11 @@ func (broker *ServiceBroker) LastOperation(ctx context.Context, instanceID strin | |||
|
|
|||
| _, serviceProvider, err := broker.getDefinitionAndProvider(instance.ServiceGUID) | |||
| if err != nil { | |||
| broker.Logger.Info("XXXX getDefinitionAndProvider", correlation.ID(ctx), lager.Data{"err": err}) | |||
| @@ -128,6 +128,14 @@ func RunMigrations(db *gorm.DB) error { | |||
| return autoMigrateTables(db, &models.BindRequestDetailsV1{}) | |||
| } | |||
|
|
|||
| migrations[16] = func() error { | |||
There was a problem hiding this comment.
This is doable in a single migration:
migrations[16] = func() error {
if err := db.Migrator().DropColumn(&models.ServiceInstanceDetailsV3{}, "operation_type"); err != nil {
return err
}
return db.Migrator().DropColumn(&models.ServiceInstanceDetailsV3{}, "operation_id")
}But I'm not such which approach is best. Given I can't find an argument that a single migration is "better" then maybe leave it as it is.
pkg/providers/tf/deprovision.go
Outdated
| @@ -12,6 +13,8 @@ import ( | |||
|
|
|||
| // Deprovision performs a terraform destroy on the instance. | |||
| func (provider *TerraformProvider) Deprovision(ctx context.Context, instanceGUID string, vc *varcontext.VarContext) (*string, error) { | |||
| fmt.Println("XXXXX YO") | |||
pkg/providers/tf/deprovision.go
Outdated
| @@ -22,6 +25,7 @@ func (provider *TerraformProvider) Deprovision(ctx context.Context, instanceGUID | |||
| return nil, err | |||
| } | |||
|
|
|||
| fmt.Println("provider.destror") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed OperationID and OperationType from service_instance_details table.
Storing this data in the service_instance_details table is redundant, since this information is also stored the terraform_deployment table. If these two sources of truth became inconsistent, there is a possiblity that a service details could be deleted incorrectly following a failed deletion. Having a single source of truth prevents this incorrect behaviour.
#TPCF-26508
Checklist: