Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "open-asgs-for-credhub" task for hermione/experimental #1189

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

jochenehret
Copy link
Contributor

WHAT is this change about?

CF CredHub deployment has been disabled for this environment, so we don't need the task that opens application security groups to CredHub.

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

See #1179

Please provide any contextual information.

See #1179

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

N/A

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

Job "experimental-deploy" is green: https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/cf-deployment/jobs/experimental-deploy

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Note: Pipeline has already been updated with this change.

* CF CredHub deployment has been disabled for this environment
Copy link
Contributor

@dimivel dimivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochenehret jochenehret merged commit decf588 into develop Jul 4, 2024
3 checks passed
@jochenehret jochenehret deleted the remove_open_asgs_credhub_task_experimental branch July 4, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants