Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Redis to Valkey #1185

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Jun 20, 2024

WHAT is this change about?

CAPI Release will switch Redis to Valkey as part of cloudfoundry/capi-release#428 . This is due to Licensing changes in Redis.

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

Types of breaking changes:
3. modifies, deletes or moves the name of a job or instance group in the main manifest

How should this change be described in cf-deployment release notes?

Replace Redis with Valkey in API instance group

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

bosh ssh api/123

ps -ef | grep valkey

/var/vcap/packages/valkey/valkey-cli -s /var/vcap/data/valkey/valkey.sock

valkey /var/vcap/data/valkey/valkey.sock> keys *
1) "metrics:cc.requests.outstanding.gauge"

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@Samze Samze marked this pull request as draft June 20, 2024 17:51
@jochenehret
Copy link
Contributor

I can merge this when we have a new capi-release with valkey.

@ctlong
Copy link
Member

ctlong commented Jun 28, 2024

I can merge this when we have a new capi-release with valkey.

Seems like there is one now: https://github.com/cloudfoundry/capi-release/releases/tag/1.184.0

@philippthun philippthun marked this pull request as ready for review July 1, 2024 08:03
@jochenehret jochenehret merged commit adacf5b into cloudfoundry:develop Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants