Add cert for TLS LB healthcheck endpoint for tcp-router #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a moment to review the questions before submitting the PR
WHAT is this change about?
Adds certs + config to use certs for the new TLS health check for tcp-router
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
Allows operators to have TLS based health checks on their tcp-router.
Please provide any contextual information.
https://www.pivotaltracker.com/story/show/186471705
https://www.pivotaltracker.com/story/show/186497091
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
tcp-router now supports a TLS based healthcheck when queried from load-balancers, on port 443.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
tcp-router responds to https:///health with a 200 (will require routing-release update before this is fully functional though)
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@ameowlia