Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readiness health check test to test audit events #997

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

ameowlia
Copy link
Member

@ameowlia ameowlia commented Dec 14, 2023

Are you submitting this PR against the develop branch?

What is this change about?

This adds a test for the new audit.app.process.ready and audit.app.process.not-ready events.

Please provide contextual information.

What version of cf-deployment have you run this cf-acceptance-test change against?

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

Less than 1!

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

@ameowlia
Copy link
Member Author

Don't merge until the new version of CAPI is released! I will update this PR when that occurs.

@ameowlia
Copy link
Member Author

ameowlia commented Jan 19, 2024

The new CAPI version is here and it is in cf-deployment. This is ready to be merged.

@jochenehret jochenehret requested a review from a team January 22, 2024 06:58
@jochenehret jochenehret merged commit 974b7f3 into develop Jan 22, 2024
1 check passed
@jochenehret jochenehret deleted the readiness-hc-events branch January 22, 2024 06:59
@ctlong
Copy link
Member

ctlong commented Jan 22, 2024

@ameowlia it seems like the app.process.not-ready audit event is not being emitted for Windows Cells in CF-D CI. Can you think of a reason why?

Off the top of my head, I wonder if

  • The timeout isn't long enough?
  • We need to set some property in a component of the Windows Cell that we're not setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants