Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(bin): update test defaults #939

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Sep 22, 2023

Are you submitting this PR against the develop branch?

Yes

What is this change about?

./bin/test should:

  • Randomize all specs. This helps suss out spec pollution.
  • Instruct Ginkgo to keep running suites even after a suite fails. This makes sure we get the full set of failures on a test run.

Please provide contextual information.

None

What version of cf-deployment have you run this cf-acceptance-test change against?

None

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

`./bin/test` should:
- Randomize all specs and randomize the order in which suites run. This
  helps suss out spec pollution.
- Instruct Ginkgo to keep running suites even after a suite fails. This
  makes sure we get the full set of failures on a test run.
@ctlong ctlong requested a review from a team September 22, 2023 17:43
@ctlong ctlong merged commit 95e83ad into develop Sep 28, 2023
3 checks passed
@ctlong ctlong deleted the chore/bin/update-test-defaults branch September 28, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants