Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the example-cats-config #451

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Fix the example-cats-config #451

merged 1 commit into from
Jan 5, 2021

Conversation

ameowlia
Copy link
Member

@ameowlia ameowlia commented Jan 4, 2021

What is this change about?

Update the example config to add required property "credhub_secret".

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176348431

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 4, 2021

CLA Signed

The committers are authorized under a signed CLA.

@jamespollard8
Copy link
Contributor

hey @ameowlia, could you please make sure you're properly associated with the commit?

Copy link
Contributor

@jamespollard8 jamespollard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me - thank you!

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176364844

The labels on this github issue will be updated when the story is started.

@ameowlia
Copy link
Member Author

ameowlia commented Jan 5, 2021

I fixed the commit and I closed+reopened in hopes that the EasyCLA would run again 🤔

Yesterday I had this same problem with this PR, but it seems to be fixed now. I wonder why not here.

add required property credhub_secret to config

Co-authored-by: George Gelashvili <ggelashvili@vmware.com>
@ameowlia
Copy link
Member Author

ameowlia commented Jan 5, 2021

I moved it from authored by george to authored by me and it seems to have fixed it. I wonder if everyone has to resign like I did yesterday?

@jamespollard8 jamespollard8 merged commit 6e4b35a into develop Jan 5, 2021
@jamespollard8 jamespollard8 deleted the fix-credhub-example branch January 5, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants