CI: Add GH actions workflow #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
force-pushed
the
ci/add-gh-actions
branch
from
db13a5e to
0329743
Compare
|
Part of #1372 |
davewalter
previously approved these changes
Dec 16, 2024
It doesn't need to run on a schedule. I added the schedule out of habit, as many of the GH actions workflows I've written in the past contain jobs that may change over time (e.g. linting). These specific jobs should be consistent without code changes though, so I'll remove the schedule. |
Removes the unnecessary schedule from the GH Actions CI workflow. The schedule is unnecessary because there's currently no external dependency in any of the jobs in the workflow that could benefit from testing over time, without code changes. For example, that usually takes the form of a linting job, where the linting tool improves over time.
davewalter
approved these changes
Dec 16, 2024
|
The revert commit above was accidental. I've deleted it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Add a GH actions workflow for CI purposes.
Please provide contextual information.
None
What version of cf-deployment have you run this cf-acceptance-test change against?
N/A
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
None
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
None