Add acceptance test for crashed app instance stats #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing an app which has crashing instances (e.g. last instance crashes) all instances should be reported with their correct state.
jochenehret
reviewed
Sep 10, 2024
jochenehret
reviewed
Sep 11, 2024
johha
previously approved these changes
Sep 17, 2024
jochenehret
requested changes
Sep 17, 2024
jochenehret
approved these changes
Sep 17, 2024
johha
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing an app which has crashing instances (e.g. last instance crashes) all instances should be reported with their correct state.
Are you submitting this PR against the develop branch?
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
Add a test when pushing an app which has crashing instances (e.g. last instance crashes) check that the states of the instances are reported correctly.
Please provide contextual information.
#3953
What version of cf-deployment have you run this cf-acceptance-test change against?
v42.3.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
~90 seconds
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@johha @jochenehret