Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pora Dockerfile to actually compile pora #1227

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

ameowlia
Copy link
Member

@ameowlia ameowlia commented Sep 5, 2024

Are you submitting this PR against the develop branch?

Yes

What is this change about?

We want to update the Dockerfile to actually work :)

Please provide contextual information.

ARP WG is taking over volume services and revamping a few things, including this.

What version of cf-deployment have you run this cf-acceptance-test change against?

CATs does not use this dockerfile

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

We want to keep pora where it is.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

0!

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

@winkingturtlevmw

Signed-off-by: Amelia Downs <amelia.downs@broadcom.com>
ctlong
ctlong previously approved these changes Sep 5, 2024
@ctlong ctlong self-assigned this Sep 5, 2024
Signed-off-by: Amin Jamali <amin.jamali@broadcom.com>
@ctlong ctlong merged commit de214fe into develop Sep 5, 2024
3 checks passed
@ctlong ctlong deleted the update-dockerfile-pora branch September 5, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants