Improve TCP Route Testing #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make it easier to configure TCP route testing by separating the TCP domains from the apps domain. - Make it possible to run isolation_segment_routing tests alongside isolation_segment_tcp_routing tests - Add TCP routing tests for windows - Improve the output returned by SendAndReceive so that text fits in gomega/ginkgo string length constraints
davewalter
reviewed
Aug 23, 2024
geofffranks
force-pushed
the
tcp-route-testing-fixes
branch
from
7dad779 to
5e2c2d1
Compare
davewalter
approved these changes
Sep 3, 2024
jochenehret
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Looks good, but there are two follow-up activities:
- Update https://github.com/cloudfoundry/cf-acceptance-tests/blob/main/example-cats-config.json with the new options (other recently added options might be missing as well)
- Use the new tcp domain options in our relint-envs test environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
Please provide contextual information.
We discovered issues with tcp routes on cross-deployment scenarios where links weren't properly being configured, and this slipped through testing because of strange nuances to how isolation segment + tcp routes work. Additionally there were no windows tcp route tests
What version of cf-deployment have you run this cf-acceptance-test change against?
Latest
Please check all that apply for this PR:
^^ adds opt-in configuration to cats?
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should test the same app/route workloads on windows as it does on isolation segments + primary diego cells
How many more (or fewer) seconds of runtime will this change introduce to CATs?
up to two cf push timeouts
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!