Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to go1.22 #1185

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Bump to go1.22 #1185

merged 3 commits into from
Aug 1, 2024

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Aug 1, 2024

Are you submitting this PR against the develop branch?

Yes

What is this change about?

  • Bump the min Go version required by this module to go1.22.0.
  • Bump the min Go version required by Go assets to go1.22.0.
  • Bump the Go version specified in Go asset manifests to go1.22.

Please provide contextual information.

None

What version of cf-deployment have you run this cf-acceptance-test change against?

None

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

@ctlong ctlong requested review from a team August 1, 2024 16:49
Copy link
Member

@davewalter davewalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (other than the YAML indentation changes 😉).

@ard-wg-gitbot
Copy link

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀

@ctlong
Copy link
Member Author

ctlong commented Aug 1, 2024

Looks good (other than the YAML indentation changes 😉).

yq man 🤷 nothing I could do. For real though, if it wasn't consistent (per-file) I wouldn't have kept it.

@ctlong
Copy link
Member Author

ctlong commented Aug 1, 2024

I need to bump the relint-base docker image golang version as well 🏃 Done

@ctlong ctlong merged commit 043a63f into develop Aug 1, 2024
3 checks passed
@ctlong ctlong deleted the bump/go-1.22 branch August 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants