Correctly print CF CLI version #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STDOUT output of fmt is not captured by ginkgo and thus the version is not printed. When using `GinkgoWriter` the message is captured correctly.
jochenehret
approved these changes
Apr 5, 2024
|
@johha do we still need the |
Still need it to show the version number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
STDOUT output of
fmtis not captured by ginkgo and thus the version is not printed. When usingGinkgoWriterthe message is captured correctly.Please check all that apply for this PR:
-> not applicable
Did you update the README as appropriate for this change?
What is the level of urgency for publishing this change?