Adjust regex for container metrics #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory/disk might be shown as 0B initially.
|
We are still unsure if there is a "real" problem with container metrics. |
|
We think this is caused by a recent bump of https://pkg.go.dev/code.cloudfoundry.org/bytefmt . |
|
We are fairly confident that the issue is arising from a bytefmt bump in cf CLI 8.7.10 that picked up this change. Accordingly, I'm going to look to merge this PR. Thanks @philippthun ! |
ctlong
previously approved these changes
Apr 4, 2024
ctlong
approved these changes
Apr 4, 2024
ctlong
pushed a commit
to loggregator/cf-acceptance-tests
that referenced
this pull request
May 13, 2024
…y#1105) Adjusts container metrics regex to allow for `cf app` output to display `memory` and `disk` output in bytes. Fixes `windows` and `apps` suite failures. Previously, the cf CLI defaulted to `K`, `M`, or `G` as the units for those columns. However, cf CLI v7.7.10/v8.7.10 bumped `code.cloudfoundry.org/bytefmt` to include [this change](cloudfoundry/bytefmt@854d396), which now outputs `B` as the unit in certain circumstances. --------- Co-authored-by: Carson Long <12767276+ctlong@users.noreply.github.com> (cherry picked from commit a169a8b)
arjun024
pushed a commit
to arjun024/cf-acceptance-tests
that referenced
this pull request
Jun 7, 2024
…y#1105) Adjusts container metrics regex to allow for `cf app` output to display `memory` and `disk` output in bytes. Fixes `windows` and `apps` suite failures. Previously, the cf CLI defaulted to `K`, `M`, or `G` as the units for those columns. However, cf CLI v7.7.10/v8.7.10 bumped `code.cloudfoundry.org/bytefmt` to include [this change](cloudfoundry/bytefmt@854d396), which now outputs `B` as the unit in certain circumstances. --------- Co-authored-by: Carson Long <12767276+ctlong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust regex that "extracts" container metrics from cf-cli output. Memory/disk might be shown as
0Binitially.Output from a failed CATS run: