Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove duplicated cf CLI version output #1041

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Jan 24, 2024

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Stops output interception from also outputting the result of the fmt.Println statement.

Please provide contextual information.

Old output:

$ ./bin/test -p
Printing sanitized $CONFIG
...
Running CATs with CF CLI version  cf version 8.7.7+583a09a.2023-12-26
...
[SynchronizedBeforeSuite] PASSED [26.126 seconds]
[SynchronizedBeforeSuite]
/Users/lcarson/workspace/cf-acceptance-tests/cats_suite_test.go:69

  Captured StdOut/StdErr Output >>
  Running CATs with CF CLI version  cf version 8.7.7+583a09a.2023-12-26

  << Captured StdOut/StdErr Output
------------------------------
...

What version of cf-deployment have you run this cf-acceptance-test change against?

v37.0.0

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

Stops output interception from also outputting the result of the
`fmt.Println` statement.
@ctlong ctlong requested review from a team January 24, 2024 17:56
@ctlong ctlong merged commit d36bc9c into develop Jan 25, 2024
3 checks passed
@ctlong ctlong deleted the chore/remove-duplicated-output branch January 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants