Remove EventMachine from DNS sync scripts #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DNS sync scripts were setting up EventMachine, but seemingly never made use of it. Additionally, the AgentBroadcaster (which is used both inside the DNS sync scripts and in the Director during deploy) had a reference to a "EmReactorLoop" class. It appears this class used to use EventMachine, but now simply yields whatever block is passed to it. Since it's just calling a block method, it has been removed in favor of just the code in the block.
This was referenced Feb 23, 2024
aramprice
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DNS sync scripts were setting up EventMachine, but seemingly never made use of it.
Additionally, the AgentBroadcaster (which is used both inside the DNS sync scripts and in the Director during deploy) had a reference to a "EmReactorLoop" class. It appears this class used to use EventMachine, but now simply yields whatever block is passed to it. Since it's just calling a block method, it has been removed in favor of just the code in the block.
See also #2497, #2499 for more removals of EventMachine.