Integrate bosh-azure-storage-cli into bosh #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fmoehler <felix.moehler@sap.com>
Malsourie
force-pushed
the
Integrate-AZCLI
branch
from
e18e65e to
8f745b4
Compare
5 tasks
mvach
requested changes
Jul 25, 2023
src/bosh-director/lib/bosh/blobstore_client/azurestoragecli_blobstore_client.rb
Show resolved
Hide resolved
src/bosh-director/lib/bosh/blobstore_client/azurestoragecli_blobstore_client.rb
Show resolved
Hide resolved
src/bosh-director/lib/bosh/blobstore_client/azurestoragecli_blobstore_client.rb
Outdated
Show resolved
Hide resolved
rkoster
requested review from
a team,
aramprice and
klakin-pivotal
and removed request for
a team
rkoster
approved these changes
Aug 3, 2023
mvach
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Integrate bosh-azure-storage-cli into bosh
Please provide contextual information.
In this PR we implement the logic code part. The bosh director will consume the blob added by #2455
What tests have you run against this PR?
src/bosh-director/spec/unit/blobstore_client/azurestoragecli_blobstore_client_spec.rb
How should this change be described in bosh release notes?
Add azure-storage as provider of blobstore
Does this PR introduce a breaking change?
No.