Hardcoded system_domain: <%= dns %>.com

[mrdavidlaing]

templates/v149/aws/medium/deployment_file.yml.erb#L162 hardcodes the system_domain to end in .com

properties:
...snip...
  domain: <%= dns %>
  system_domain: <%= dns %>.com

I think this is an error; at least it breaks my deployment to *.co.uk.

Specifically, my loggregator tries to register itself to "uris":["loggregator.mydomain.co.uk.com"]

when it should register to "uris":["loggregator.mydomain.co.uk"]

[drnic]

Thought that was fixed. The two domains currently must be the same. No idea why we have the two. Loggregator uses the system_domain and then goes and shares the value with the CLI user. Remove the .com

On Mon, Dec 16, 2013 at 4:00 AM, David Laing notifications@github.com
wrote:

templates/v149/aws/medium/deployment_file.yml.erb#L162 hardcodes the system_domain to end in .com

properties:
...snip...
  domain: <%= dns %>
  system_domain: <%= dns %>.com

I think this is an error; at least it breaks my deployment to *.co.uk.
Specifically, my loggregator tries to register itself to "uris":["loggregator.mydomain.co.uk.com"]

when it should register to "uris":["loggregator.mydomain.co.uk"]

Reply to this email directly or view it on GitHub:
#267