Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address devtools console errors #10

Closed
adamschwartz opened this issue Nov 12, 2019 · 5 comments · Fixed by #98
Closed

Address devtools console errors #10

adamschwartz opened this issue Nov 12, 2019 · 5 comments · Fixed by #98
Assignees
@kristianfreeman
Milestone
Post launch cleanup

Comments

@adamschwartz
Copy link
Contributor

@signalnerve would appreciate your help with these.

image
kristianfreeman added a commit that referenced this issue Nov 14, 2019
@kristianfreeman
Fix console warnings
b23f944 
This PR fixes console warnings across the application by:

- moving `class` to `className`
- adding a `key` prop when looping through an array of items and outputting it to the DOM (see [the docs](https://reactjs.org/docs/lists-and-keys.html) for explanation on this)
- moving `stop-opacity` and `stop-color` to `stopOpacity` and `stopColor`, respectively

Closes #10
@kristianfreeman kristianfreeman mentioned this issue Nov 14, 2019
Closed
@adamschwartz adamschwartz added this to the MVP GTM milestone Dec 2, 2019
@adamschwartz
Copy link
Contributor Author

Fixed a few 6a937f7

@adamschwartz
Copy link
Contributor Author

There are still some on the deployed testing/staging site:

https://built-with-workers.signalnerve.workers.dev/built-with/

image

@kristianfreeman
Copy link
Contributor

Punting on img lazy loading issue: gatsbyjs/gatsby#17506

Same site cookie warning is on the server side (Cloudflare, Sanity etc need to add some config on their end): https://stackoverflow.com/questions/58270663/samesite-warning-chrome-77

@adamschwartz
Copy link
Contributor Author

Re: lazy loading, can we instruct Gatsby to specify dimension attributes on the HTML based on a max width (e.g. width="100vw" height="100vh" [or, at runtime, the computed pixel value version of these if possible]) just to silence the warning? (The CSS would override to make it fluid.)

Re: same site cookie, Is this something we have control over in Cloudflare and/or Sanity?

kristianfreeman added a commit that referenced this issue Feb 14, 2020
@kristianfreeman
Clean up some hooks deps usage
85061fb 
Fixes #10 by closing some console warnings
@kristianfreeman kristianfreeman mentioned this issue Feb 14, 2020
Merged
@kristianfreeman
Copy link
Contributor

Re: lazy loading, can we instruct Gatsby to specify dimension attributes on the HTML based on a max width (e.g. width="100vw" height="100vh" [or, at runtime, the computed pixel value version of these if possible]) just to silence the warning? (The CSS would override to make it fluid.)

if you'd like me to, (i think) i can do that – can pass in some values to the gatsby-image pkg. fwiw this is a chrome-specific error and a bug report in chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=1002455) so it feels like we're not doing anything wrong here!

Re: same site cookie, Is this something we have control over in Cloudflare and/or Sanity?

nope, unfortunately :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristianfreeman kristianfreeman

Labels
None yet
Projects
None yet
Milestone
Post launch cleanup
2 participants
@adamschwartz @kristianfreeman