This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Updated types for 2021-12-21 #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
reviewed
Dec 21, 2021
| @@ -788,6 +788,7 @@ declare class ReadableStream { | |||
| pipeThrough(transform: ReadableStreamTransform, options?: PipeToOptions): ReadableStream; | |||
| pipeTo(destination: WritableStream, options?: PipeToOptions): Promise<void>; | |||
| tee(): [ReadableStream, ReadableStream]; | |||
| values(options?: ReadableStreamValuesOptions): ReadableStreamReadableStreamAsyncIterator; | |||
There was a problem hiding this comment.
Is [Symbol.asyncIterator] implemented and just not showing up, or is that coming soon? cc @jasnell
There was a problem hiding this comment.
It's landed. I think it might be going out this week.
| declare class ReadableStreamReadableStreamAsyncIterator { | ||
| constructor(underlyingSource?: Object, queuingStrategy?: Object); | ||
| next(): Promise<ReadableStreamReadResult<any>>; | ||
| return(reason?: any): Promise<ReadableStreamReadResult<any>>; |
There was a problem hiding this comment.
Would be good to make all stream types generic at some point.
|
@threepointone Are you wanting the CI to do something like this for the Release workflow? |
|
Closing this since we landed #181 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the auto-generated types generated on
2021-12-21.