Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Router-worker loss of sentry + metrics on error #7901

Closed

Conversation

WillTaylorDev
Copy link
Contributor

Fixes a bug where router-worker lost the ability to send error metrics.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: n/a
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 0c07733

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev marked this pull request as ready for review January 24, 2025 21:22
@WillTaylorDev WillTaylorDev requested review from a team as code owners January 24, 2025 21:22
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/catch-errors-jaeger-router-worker branch from d779a10 to 58ed73a Compare January 24, 2025 21:24
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/catch-errors-jaeger-router-worker branch from 58ed73a to 0c07733 Compare January 24, 2025 22:10
Copy link
Contributor

github-actions bot commented Jan 24, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-wrangler-7901

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7901/npm-package-wrangler-7901

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-wrangler-7901 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-workers-bindings-extension-7901 -O ./cloudflare-workers-bindings-extension.0.0.0-v0aa06c20f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v0aa06c20f.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-create-cloudflare-7901 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-kv-asset-handler-7901

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-miniflare-7901

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-pages-shared-7901

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-unenv-preset-7901

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-vite-plugin-7901

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-vitest-pool-workers-7901

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-workers-editor-shared-7901

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-workers-shared-7901

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12958444061/npm-package-cloudflare-workflows-shared-7901

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.105.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant