Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run non-network E2E tests #7872

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Always run non-network E2E tests #7872

wants to merge 21 commits into from

Conversation

penalosa
Copy link
Contributor

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 9c81fc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Jan 23, 2025
@penalosa penalosa removed the e2e Run e2e tests on a PR label Jan 23, 2025
@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-wrangler-7872

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7872/npm-package-wrangler-7872

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-wrangler-7872 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-workers-bindings-extension-7872 -O ./cloudflare-workers-bindings-extension.0.0.0-v555879063.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v555879063.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-create-cloudflare-7872 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-kv-asset-handler-7872

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-miniflare-7872

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-pages-shared-7872

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-unenv-preset-7872

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-vite-plugin-7872

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-vitest-pool-workers-7872

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-workers-editor-shared-7872

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-workers-shared-7872

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12921907818/npm-package-cloudflare-workflows-shared-7872

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.105.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa removed the e2e Run e2e tests on a PR label Jan 23, 2025
@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Jan 23, 2025
@penalosa penalosa removed the e2e Run e2e tests on a PR label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants