Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add welcome/reference webview to vscode extension #7777

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Jan 15, 2025

Fixes DEVX-1546

Screenshot 2025-01-15 at 15 35 12 Screenshot 2025-01-15 at 15 35 12

(slightly out of date screenshot showing this in dark mode)


  • Tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e tests for this
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: unreleased

@emily-shen emily-shen requested a review from a team as a code owner January 15, 2025 13:31
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 4cbd490

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cloudflare-workers-bindings-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen changed the base branch from main to emily/extension-fixups January 15, 2025 13:31
@emily-shen emily-shen marked this pull request as draft January 15, 2025 13:32
Copy link
Contributor

github-actions bot commented Jan 15, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-wrangler-7777

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7777/npm-package-wrangler-7777

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-wrangler-7777 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workers-bindings-extension-7777 -O ./cloudflare-workers-bindings-extension.0.0.0-vaac42b89a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vaac42b89a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-create-cloudflare-7777 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-kv-asset-handler-7777

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-miniflare-7777

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-pages-shared-7777

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-unenv-preset-7777

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-vite-plugin-7777

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-vitest-pool-workers-7777

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workers-editor-shared-7777

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workers-shared-7777

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workflows-shared-7777

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.105.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen force-pushed the emily/ext-fixups-the-second branch from e1d162d to 564b123 Compare January 15, 2025 15:37
@emily-shen emily-shen marked this pull request as ready for review January 16, 2025 16:55
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've tested this in every theme I have installed in VSCode, and it seems to render properly in all

Base automatically changed from emily/extension-fixups to main January 23, 2025 19:08
@emily-shen emily-shen force-pushed the emily/ext-fixups-the-second branch 2 times, most recently from ea6b7e7 to cf9d779 Compare January 23, 2025 19:30
@emily-shen emily-shen force-pushed the emily/ext-fixups-the-second branch from cf9d779 to 7418f78 Compare January 23, 2025 19:32
@emily-shen emily-shen merged commit 248bdb2 into main Jan 24, 2025
33 checks passed
@emily-shen emily-shen deleted the emily/ext-fixups-the-second branch January 24, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants