-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add welcome/reference webview to vscode extension #7777
Conversation
🦋 Changeset detectedLatest commit: 4cbd490 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-wrangler-7777 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7777/npm-package-wrangler-7777 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-wrangler-7777 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workers-bindings-extension-7777 -O ./cloudflare-workers-bindings-extension.0.0.0-vaac42b89a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vaac42b89a.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-create-cloudflare-7777 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-kv-asset-handler-7777 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-miniflare-7777 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-pages-shared-7777 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-unenv-preset-7777 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-vite-plugin-7777 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-vitest-pool-workers-7777 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workers-editor-shared-7777 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workers-shared-7777 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12943563029/npm-package-cloudflare-workflows-shared-7777 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
e1d162d
to
564b123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I've tested this in every theme I have installed in VSCode, and it seems to render properly in all
ea6b7e7
to
cf9d779
Compare
cf9d779
to
7418f78
Compare
Fixes DEVX-1546
(slightly out of date screenshot showing this in dark mode)