Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(unenv-preset): drop unused .cjs files #7697

Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore(unenv-preset): drop unused .cjs files #7697

merged 1 commit into from
Jan 8, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 8, 2025

Use tsc to compile @cloudflare/unenv-preset

/cc @pi0


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: tested locally
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

@vicb vicb requested a review from a team as a code owner January 8, 2025 10:14
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 3862f91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/unenv-preset Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from petebacondarwin January 8, 2025 10:16
Copy link
Contributor

github-actions bot commented Jan 8, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-wrangler-7697

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7697/npm-package-wrangler-7697

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-wrangler-7697 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-workers-bindings-extension-7697 -O ./cloudflare-workers-bindings-extension.0.0.0-v87ea6cfc0.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v87ea6cfc0.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-create-cloudflare-7697 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-kv-asset-handler-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-miniflare-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-pages-shared-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-unenv-preset-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-vitest-pool-workers-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-workers-editor-shared-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-workers-shared-7697
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12669974818/npm-package-cloudflare-workflows-shared-7697

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.100.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb force-pushed the tsc-unenv branch 2 times, most recently from 37a46c6 to 351fac1 Compare January 8, 2025 11:24
@vicb vicb changed the title chore(unenv-preset): switch from unbuild to tsc chore(unenv-preset): drop unused .cjs files Jan 8, 2025
@vicb
Copy link
Contributor Author

vicb commented Jan 8, 2025

Thanks for the reviews and feedback @petebacondarwin and @pi0

I have updated the PR to keep unbuild but drop .cjs files.
The output dir has been changed to dist/src as dist/tests will be created in a follow up PR.

@vicb vicb merged commit 3e2bede into main Jan 8, 2025
29 checks passed
@vicb vicb deleted the tsc-unenv branch January 8, 2025 14:30
@workers-devprod workers-devprod mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants