Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset upload count messaging #6687

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Sep 12, 2024

What this PR solves / how to test

Fixes main (red right now because of conflict on merge).

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: no coverage
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: bugfix, not user-facing

@GregBrimble GregBrimble requested a review from a team as a code owner September 12, 2024 12:00
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 28b1f76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-wrangler-6687

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6687/npm-package-wrangler-6687

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-wrangler-6687 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-create-cloudflare-6687 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-cloudflare-kv-asset-handler-6687
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-miniflare-6687
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-cloudflare-pages-shared-6687
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-cloudflare-vitest-pool-workers-6687
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-cloudflare-workers-editor-shared-6687
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10830327367/npm-package-cloudflare-workers-shared-6687

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.76.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble merged commit 7bbed63 into main Sep 12, 2024
21 checks passed
@GregBrimble GregBrimble deleted the fix-conflict-for-asset-upload-messaging branch September 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants